Add middleware proxy, skeleton and cluster connections#363
Open
dcavalei wants to merge 1 commit intoeclipse-openbsw:mainfrom
Open
Add middleware proxy, skeleton and cluster connections#363dcavalei wants to merge 1 commit intoeclipse-openbsw:mainfrom
dcavalei wants to merge 1 commit intoeclipse-openbsw:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a first implementation of the middleware “core” (proxy/skeleton base classes, cluster connections, database manipulation, logger API), plus platform abstraction headers and a fairly extensive unit test suite with mocks/stubs and CMake wiring to build/link the new middleware library.
Changes:
- Add core middleware runtime sources (ClusterConnection*, ProxyBase, SkeletonBase, DatabaseManipulator, LoggerApi) and corresponding public headers.
- Add platform abstraction APIs (logger, time, task/process id, lock strategies) and test-only stub/mock implementations.
- Expand middleware unit test executable to cover the new core components.
Reviewed changes
Copilot reviewed 45 out of 47 changed files in this pull request and generated 17 comments.
Show a summary per file
| File | Description |
|---|---|
| libs/bsw/middleware/test/src/time/mock/SystemTimerProviderMock.h | Adds gmock interface for time provider in tests |
| libs/bsw/middleware/test/src/time/mock/SystemTimerProviderMock.cpp | Test stub wiring for SystemTimerProvider |
| libs/bsw/middleware/test/src/os/OsDefinitions.cpp | Test stub for getProcessId() |
| libs/bsw/middleware/test/src/logger/mock/LoggerMock.h | Adds gmock logger interface for tests |
| libs/bsw/middleware/test/src/logger/mock/LoggerMock.cpp | Test implementation of middleware::logger::* routed to mock |
| libs/bsw/middleware/test/src/logger/DslLogger.h | Test DSL helper for asserting formatted/binary logs |
| libs/bsw/middleware/test/src/core/skeleton.h | Test skeleton mock helper |
| libs/bsw/middleware/test/src/core/proxy.h | Test proxy mock helper |
| libs/bsw/middleware/test/src/core/middleware_skeleton_base_unittest.cpp | Adds UTs for SkeletonBase behaviors |
| libs/bsw/middleware/test/src/core/middleware_proxy_base_unittest.cpp | Adds UTs for ProxyBase behaviors |
| libs/bsw/middleware/test/src/core/middleware_message_unittest.cpp | Minor formatting fix in existing message UT |
| libs/bsw/middleware/test/src/core/middleware_logger_api.cpp | Adds UTs for the new logger API helpers |
| libs/bsw/middleware/test/src/core/middleware_instances_database.h | Adds test instance DB + fake cluster connections |
| libs/bsw/middleware/test/src/core/middleware_db_manipulator_unittest.cpp | Adds UTs for DatabaseManipulator |
| libs/bsw/middleware/test/src/core/middleware_connection_unittest.cpp | Adds UTs for ClusterConnection base behavior |
| libs/bsw/middleware/test/src/core/middleware_cluster_configuration_unittest.cpp | Adds UTs for configuration dispatching + timeout registration |
| libs/bsw/middleware/test/src/concurrency/ConcurrencyDefinitions.cpp | Test stub implementations for lock strategy types |
| libs/bsw/middleware/test/CMakeLists.txt | Expands test target sources and links to new middleware library |
| libs/bsw/middleware/src/middleware/core/SkeletonBase.cpp | Implements SkeletonBase init/send/unsubscribe/thread-check |
| libs/bsw/middleware/src/middleware/core/ProxyBase.cpp | Implements ProxyBase init/send/header-gen/thread-check |
| libs/bsw/middleware/src/middleware/core/LoggerApi.cpp | Implements structured logging helpers (text + binary) |
| libs/bsw/middleware/src/middleware/core/IClusterConnectionConfigurationBase.cpp | Implements default dispatch + timeout registration helpers |
| libs/bsw/middleware/src/middleware/core/DatabaseManipulator.cpp | Implements DB subscription/unsubscription/search helpers |
| libs/bsw/middleware/src/middleware/core/ClusterConnectionBase.cpp | Implements base send/dispatch/error-response behavior |
| libs/bsw/middleware/src/middleware/core/ClusterConnection.cpp | Implements concrete cluster connection wrappers over configs |
| libs/bsw/middleware/include/middleware/time/SystemTimerProvider.h | Adds platform API for monotonic time |
| libs/bsw/middleware/include/middleware/os/TaskIdProvider.h | Adds platform API for task/process id |
| libs/bsw/middleware/include/middleware/logger/Logger.h | Adds platform logger API + enums |
| libs/bsw/middleware/include/middleware/core/types.h | Updates HRESULT values/names |
| libs/bsw/middleware/include/middleware/core/traits.h | Adds small traits utilities (span trait, CopyPolicy detection) |
| libs/bsw/middleware/include/middleware/core/TransceiverContainer.h | Adds container + comparators for transceiver registry |
| libs/bsw/middleware/include/middleware/core/SkeletonBase.h | Adds SkeletonBase public/protected API |
| libs/bsw/middleware/include/middleware/core/ProxyBase.h | Adds ProxyBase public/protected API |
| libs/bsw/middleware/include/middleware/core/Message.h | Minor formatting fix at namespace close |
| libs/bsw/middleware/include/middleware/core/LoggerApi.h | Declares structured logging helpers + byte-size traits |
| libs/bsw/middleware/include/middleware/core/InstancesDatabase.h | Declares instance DB interface |
| libs/bsw/middleware/include/middleware/core/ITransceiver.h | Declares base transceiver interface |
| libs/bsw/middleware/include/middleware/core/ITimeout.h | Declares timeout transceiver interface |
| libs/bsw/middleware/include/middleware/core/IClusterConnectionConfigurationBase.h | Declares config interfaces (proxy/skeleton/bidir + timeout) |
| libs/bsw/middleware/include/middleware/core/IClusterConnection.h | Declares cluster connection interface(s) |
| libs/bsw/middleware/include/middleware/core/DatabaseManipulator.h | Declares database manipulation API + dummy transceiver |
| libs/bsw/middleware/include/middleware/core/ClusterConnectionBase.h | Declares base connection classes |
| libs/bsw/middleware/include/middleware/core/ClusterConnection.h | Declares concrete cluster connection types + type selector |
| libs/bsw/middleware/include/middleware/concurrency/LockStrategies.h | Declares lock strategy API + lock macros |
| libs/bsw/middleware/doc/dd/queue.rst | Updates docs to refer to Message instead of MiddlewareMessage |
| libs/bsw/middleware/doc/dd/core.rst | Updates core docs to refer to Message instead of MiddlewareMessage |
| libs/bsw/middleware/CMakeLists.txt | Adds middleware library target and links includes/etl |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
libs/bsw/middleware/include/middleware/concurrency/LockStrategies.h
Outdated
Show resolved
Hide resolved
libs/bsw/middleware/src/middleware/core/IClusterConnectionConfigurationBase.cpp
Outdated
Show resolved
Hide resolved
| { | ||
| auto const range = meta::DbManipulator::getTransceiversByServiceIdAndServiceInstanceId( | ||
| proxiesStart, proxiesEnd, msg.getHeader().serviceId, msg.getHeader().serviceInstanceId); | ||
| for (auto const* it = range.first; it != range.second; it = etl::next(it)) |
There was a problem hiding this comment.
In the event-dispatch loop, range.first / range.second are iterators; declaring it as auto const* adds an extra indirection level and is very likely a compile error for ETL iterators (which are typically raw pointers). Use auto it = range.first; (and increment with ++it or etl::next(it) as desired).
Suggested change
| for (auto const* it = range.first; it != range.second; it = etl::next(it)) | |
| for (auto it = range.first; it != range.second; it = etl::next(it)) |
libs/bsw/middleware/src/middleware/core/DatabaseManipulator.cpp
Outdated
Show resolved
Hide resolved
dcavalei
commented
Feb 4, 2026
Contributor
|
Hi! Copilot review raised some valid points. Please also adjust the PR and commit messages according to the guidelines at Squash commits where reasonable (as hinted by same descriptions). |
dcavalei
force-pushed
the
fork-main
branch
8 times, most recently
from
d9b670f to
e769640
Compare
rolandreichweinbmw
changed the title
Author
|
please do NOT MERGE, thanks |
Author
|
@johannes-esr , this is ready for review, thanks! |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add middleware proxy, skeleton and cluster connections
See also: #194